Serve the badge as svg type.

- Hack the React view engine to support SVG, see reactjs/express-react-views#53
depcheck · Oct 21, 2015 · 7dd0294 · 7dd0294
1 parent 9a12865
commit 7dd0294
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/controllers/index.js b/src/controllers/index.js
@@ -40,7 +40,7 @@ router.route('/token/:provider/:user/:repo')
 // must place the svg router before the next one.
 router.get('/:provider/:user/:repo/:branch/:report?.svg', (req, res) =>
   reportModel.get(req.params)
-  .then(result => res.render('badge', result)));
+  .then(result => res.type('svg').render('badge', result)));
 
 router.route('/:provider/:user/:repo/:report?')
   .get(loginModel.validate, (req, res) =>

diff --git a/src/index.js b/src/index.js
@@ -18,7 +18,15 @@ app.set('view engine', 'js');
 
 app.engine('js', (filePath, options, callback) => {
   logger.debug(`[app] render view file [${filePath}].`);
-  return viewEngine(filePath, options, callback);
+  return viewEngine(filePath, options, (error, html) => {
+    // HACK to support serve SVG, see reactjs/express-react-views#53
+    const raw = html.substring('<!DOCTYPE html>'.length);
+    const hack = raw.indexOf('<svg') === 0
+      ? raw.replace('<svg', '<svg xmlns="http://www.w3.org/2000/svg"')
+      : html;
+
+    callback(error, hack);
+  });
 });
 
 app.use((req, res, next) => {