feat(async/unstable): add support for AbortSignal in pooledMap#7014
Open
tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
Open
feat(async/unstable): add support for AbortSignal in pooledMap#7014tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
pooledMap#7014tomas-zijdemans wants to merge 6 commits intodenoland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7014 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 624 625 +1
Lines 49629 49723 +94
Branches 8721 8748 +27
=======================================
+ Hits 46571 46660 +89
- Misses 2478 2482 +4
- Partials 580 581 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Mar 6, 2026
| * @returns The async iterator with the transformed values. | ||
| * @throws {RangeError} If `poolLimit` is not a positive integer. | ||
| */ | ||
| export function pooledMap<T, R>( |
Member
There was a problem hiding this comment.
hmm this function signature is incompatible with the existing one. we can't stabilize this version as is. can we somehow invent something else which isn't a breaking change? (maybe we have to use overload?)
Contributor
Author
There was a problem hiding this comment.
Goog point! I pushed a new commit using overloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.