Skip to content

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Sep 28, 2025

closes #6836

With this change, @std/cli now depends on @std/internal.

@ryuapp ryuapp requested a review from kt3k as a code owner September 28, 2025 13:46
@github-actions github-actions bot added the cli label Sep 28, 2025
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.18%. Comparing base (aea9257) to head (9354f85).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/prompt_secret.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6837      +/-   ##
==========================================
+ Coverage   94.17%   94.18%   +0.01%     
==========================================
  Files         575      575              
  Lines       42449    42446       -3     
  Branches     6743     6742       -1     
==========================================
+ Hits        39976    39978       +2     
+ Misses       2423     2418       -5     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title fix(cli): avoid including Deno API when using deno bundle fix(cli): improve Node compatibility by removing top-level Deno API usage Sep 29, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b58b295 into denoland:main Sep 29, 2025
20 checks passed
@ryuapp ryuapp deleted the fix/avoid-deno-api-when-using-deno-bundle branch September 29, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseArgs() from @std/cli with deno bundle cannot be used with Node.js
2 participants