Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(cli/unstable): remove trailing whitespaces from ProgressBarFormatter properties #6502

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner March 21, 2025 09:16
@github-actions github-actions bot added the cli label Mar 21, 2025
@timreichen timreichen changed the title BREAKING(cli/unstable): remove trailing whitespaces from ProgressBar fmt properties BREAKING(cli/unstable): remove trailing whitespaces from ProgressBarFormatter properties Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (1c1ba46) to head (0e03c84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6502      +/-   ##
==========================================
- Coverage   95.30%   95.30%   -0.01%     
==========================================
  Files         576      576              
  Lines       43336    43336              
  Branches     6483     6483              
==========================================
- Hits        41301    41300       -1     
- Misses       1994     1995       +1     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Mar 24, 2025

Can you rebase? I think this one can be landed independent of other breaking changes (listed in #6501 ) as this should have less effect to the user's code (I guess there should be very small usage of fmt option for now)

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit d93f29a into denoland:main Mar 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants