fix(toml): handle hexadecimal, octal, and binary numbers #6496
Conversation
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
==========================================
- Coverage 95.30% 95.29% -0.01%
==========================================
Files 575 575
Lines 43279 43307 +28
Branches 6467 6473 +6
==========================================
+ Hits 41247 41271 +24
- Misses 1993 1995 +2
- Partials 39 41 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
toml/_parser.ts
Outdated
| // Determine the base and parse | ||
| let base: number; | ||
| switch (prefix) { | ||
| case "0b": | ||
| base = 2; | ||
| break; | ||
| case "0o": | ||
| base = 8; | ||
| break; | ||
| case "0x": | ||
| base = 16; | ||
| break; | ||
| default: | ||
| return failure(); | ||
| } |
There was a problem hiding this comment.
You can just determine the base in the above switch rather than making another one
There was a problem hiding this comment.
that's feasible too, although this works as well
There was a problem hiding this comment.
should i change the code to do it that way?
There was a problem hiding this comment.
Yes, that can avoid duplicate code
There was a problem hiding this comment.
alright, I'll do it.
kt3k
changed the title
Fixes the error in #6490. Also handles octal and binary.
The tests for these have also been updated.
Files changed: toml/_parser.ts and toml/parse_test.ts