-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for breaking changes for ProgressBar #6501
Comments
I think we first need to settle on #6407 to start landing these changes |
On a somewhat related, somewhat different direction, both ProgressBar and Spinner have a flaw in their design in two ways.
I think their design needs to be reworked entirely to resolve these issues. I believe the first issue can be fixed by using some different terminal control sequences to move the cursor for rewrites instead of clearing the current line before writing again. For the second issue, I think it would be better if the APIs acted as if they were controlling some global state and not creating a piece of memory to be passed around. With this global state type of design, we could also allow more complex outputs in the terminal like multiple progress bars/ spinners or possibly even getting user input while a progress bar also updates on screen. |
A few other things I noticed:
|
We are planning to make the breaking changes below for
ProgressBar
unstable API:ProgressBar
end()
method tostop()
#6406ProgressBar
writable
optional #6409ProgressBar
value
andmax
properties public #6430The changes below could also be related:
ProgressBar
options
optional #6407ProgressBar
start()
method #6408The text was updated successfully, but these errors were encountered: