Skip to content

Remove v8_enable_shared_ro_heap=false and v8_enable_verify_heap=false #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove v8_enable_shared_ro_heap=false and v8_enable_verify_heap=false #1788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,6 @@ default_args = {
v8_array_buffer_internal_field_count = 2
v8_array_buffer_view_internal_field_count = 2

# Enabling the shared read-only heap comes with a restriction that all
# isolates running at the same time must be created from the same snapshot.
# This is problematic for Deno, which has separate "runtime" and "typescript
# compiler" snapshots, and sometimes uses them both at the same time.
v8_enable_shared_ro_heap = false

# V8 11.6 hardcoded an assumption in `mksnapshot` that shared RO heap
# is enabled. In our case it's disabled so without this flag we can't
# compile.
v8_enable_verify_heap = false

# Enable V8 object print for debugging.
# v8_enable_object_print = true

Expand Down
Loading