Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion ext/node/polyfills/worker_threads.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,11 @@ import {
} from "ext:deno_web/01_broadcast_channel.js";
import { untransferableSymbol } from "ext:deno_node/internal_binding/util.ts";
import process from "node:process";
import { fileURLToPath } from "node:url";
import { createRequire } from "node:module";

const {
ArrayIsArray,
encodeURIComponent,
Error,
FunctionPrototypeCall,
Expand Down Expand Up @@ -218,10 +220,29 @@ class NodeWorker extends EventEmitter {
}
// When envOpt === SHARE_ENV, env_ stays undefined and the worker
// will use the default process.env backed by Deno.env (shared OS env).

// Handle the `argv` option: must be an array or undefined.
// Values are coerced to strings like Node.js does.
let argv_: string[] | undefined = undefined;
if (options?.argv != null) {
if (!ArrayIsArray(options.argv)) {
throw new ERR_INVALID_ARG_TYPE(
"options.argv",
"Array",
options.argv,
);
}
argv_ = [];
for (let i = 0; i < options.argv.length; i++) {
argv_[i] = String(options.argv[i]);
}
}

const serializedWorkerMetadata = serializeJsMessageData({
workerData: options?.workerData,
environmentData: environmentData,
env: env_,
argv: argv_,
name: this.#name,
isEval: !!options?.eval,
isWorkerThread: true,
Expand Down Expand Up @@ -596,7 +617,7 @@ internals.__initWorkerThreads = (
moduleSpecifier &&
StringPrototypeStartsWith(moduleSpecifier, "file:")
) {
scriptPath = new URL(moduleSpecifier).pathname;
scriptPath = fileURLToPath(moduleSpecifier);
} else {
scriptPath = moduleSpecifier ?? "";
}
Expand Down
2 changes: 1 addition & 1 deletion tests/node_compat/config.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,7 @@
// "parallel/test-worker-name.js": {},
"parallel/test-worker-on-process-exit.js": {},
"parallel/test-worker-onmessage.js": {},
// "parallel/test-worker-process-argv.js": {},
"parallel/test-worker-process-argv.js": {},
"parallel/test-worker-process-env.js": {},
// TODO(bartlomieju): this test just hangs
// "parallel/test-worker-process-env-shared.js": {},
Expand Down
Loading