chore(ext/cron): rewrite in js #32027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
rewrite-cron
branch
4 times, most recently
from
2cf92dd to
014cd71
Compare
devsnek
force-pushed
the
rewrite-cron
branch
2 times, most recently
from
4fdbc90 to
421dbe6
Compare
lucacasonato
reviewed
Feb 3, 2026
Member
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
I don't particularly like that we will now export a public span for this internal HTTP server. Can you label it in some way that makes it filterable?
devsnek
force-pushed
the
rewrite-cron
branch
2 times, most recently
from
36cb025 to
e16687b
Compare
arnauorriols
reviewed
Feb 3, 2026
Member
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
You removed the traceparent propagation when executing crons.
| } | ||
| } | ||
|
|
||
| setMainReadyCron(); |
Member
There was a problem hiding this comment.
Crons will never register if the entrypoint never resolves, right?
Member
Author
There was a problem hiding this comment.
they can be registered until the entrypoint resolves, then they're locked in.
Member
Author
do you mean on a per-websocket-execute-message basis? |
Member
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite crons in js for simplicity, also rework the cron sock to be a bit easier to work with by using websockets.