Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): basic event recording #28552

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

CertainLach
Copy link
Contributor

Partially fixes #27917: there is no attribute support, they are silently dropped and counted, not much worse that current links support.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

@CertainLach
Copy link
Contributor Author

recordException should also be implemented as event, but it doesn't make sense yet, as there is no attribute support.

This pull request is primarily for me to get acquainted with the Deno codebase and understand how everything works here. As a next step, I plan a larger one, with an attempt to implement support for attributes in links and events.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this looks good!

Because this is an unstable feature we'll land it in the next patch release, which will be out tomorrow

@ry ry merged commit 7ac8130 into denoland:main Mar 20, 2025
18 checks passed
@CertainLach CertainLach deleted the feature/otel-basic-events branch March 20, 2025 20:59
ry pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otel] add support for events on spans
3 participants