Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2 at fixing
process.stdin
pause.Currently, there is no way to pause ongoing reads. This PR adds
op_io_read_stop
that races against the blocking read task essentially like a CancelHandle but resets for every read.I don't think this is the right fix yet, there are still fundamental differences and assumption that read ops are always active and don't pause. This sometimes causes
readStop()
to prematurely exit as the event loop sees there are no tasks left.Fixes #26403