-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node compat): shake-128, shake-256 aliases for shake128 and shake256 hash algorithms #28451
base: main
Are you sure you want to change the base?
Conversation
…256 digest algorithms
Signed-off-by: Arsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
EDIT: Dismissed my review. Looks like somewhere else the aliases need to be wired up too. I'll leave it to @littledivy
The tests were failing because The other test failure looks like a flaky one:
|
@littledivy This is ready to review. |
node:crypto
don't support the same inputs as Node.js #28442crypto_hash_test.ts
locally against a debug build. The debug build passes, the current stable release fails.