chore(ext/http): add "legacy_abort" feature flag #28371
Merged
+92
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 4, 2025
littledivy
changed the title
ry
reviewed
Mar 13, 2025
ry
reviewed
Mar 18, 2025
Comment on lines
+135
to
+136
| /// If `false`, the server will abort the request when the response is dropped. | ||
| pub no_legacy_abort: bool, |
There was a problem hiding this comment.
When is this set to true? Ideally it would be an unstable feature flag
ry
approved these changes
Mar 21, 2025
littledivy
added a commit
that referenced
this pull request
Mar 28, 2025
Deno.serve `Request` abort signals are aborted by default even when it is finished successfully. This PR gates this behavior behind the "legacy_abort" which is the default right now. Turning the `no_legacy_abort` runtime option on is a **breaking change** and will only abort request signals when there is a failure, thereby cannot be used to determine if the request finished. This aligns with `fetch` API. Ref #27005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno.serve
Requestabort signals are aborted by default even when it is finished successfully. This PR gates this behavior behind the "legacy_abort" which is the default right now.Turning the
no_legacy_abortruntime option on is a breaking change and will only abort request signals when there is a failure, thereby cannot be used to determine if the request finished. This aligns withfetchAPI.Fixes #27005