Allow using keyword with pool clients (#473)

* feat: Allow `using` keyword with pool clients * chore: fix deno lint error
denodrivers · Feb 28, 2024 · 5e9075a · 5e9075a · github-actions · Feb 28, 2024
1 parent 5915574
commit 5e9075a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/client.ts b/client.ts
@@ -515,4 +515,8 @@ export class PoolClient extends QueryClient {
     // Cleanup all session related metadata
     this.resetSessionMetadata();
   }
+
+  [Symbol.dispose]() {
+    this.release();
+  }
 }
diff --git a/query/array_parser.ts b/query/array_parser.ts
@@ -20,7 +20,7 @@ export function parseArray<T>(
   source: string,
   transform: Transformer<T>,
   separator: AllowedSeparators = ",",
-) {
+): ArrayResult<T> {
   return new ArrayParser(source, transform, separator).parse();
 }
 

diff --git a/tests/pool_test.ts b/tests/pool_test.ts
@@ -140,3 +140,15 @@ Deno.test(
     );
   }),
 );
+
+Deno.test(
+  "Pool client will be released after `using` block",
+  testPool(async (POOL) => {
+    const initialPoolAvailable = POOL.available;
+    {
+      using _client = await POOL.connect();
+      assertEquals(POOL.available, initialPoolAvailable - 1);
+    }
+    assertEquals(POOL.available, initialPoolAvailable);
+  }),
+);