Skip to content

Conversation

smoyer64
Copy link
Contributor

@smoyer64 smoyer64 commented Jun 3, 2019

Resolves #46

@dennwc
Copy link
Owner

dennwc commented Jun 3, 2019

Sorry, I don't think this should be added. This change unconditionally creates a title element in the DOM, which might or might not be desired.

@smoyer64
Copy link
Contributor Author

smoyer64 commented Jun 3, 2019

Ah ... that it does (and leaves it empty). The one in my library is Title() so it only creates the element if you ask for it. I was also looking into the failing unit test - the underlying code compiles and then works in the browser.

Would you be open to Title() and SetTitle() functions for this? ... the <title> element (and others) are "special": https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title. I suppose another alternative is to export getFirstWithTag which is about 70% of the code I discovered was duplicated in my library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add document title element to those available through global.go

2 participants