Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): copy as command #3544

Merged
merged 8 commits into from
Sep 23, 2022
Merged

Conversation

Harshita-mindfire
Copy link
Contributor

@Harshita-mindfire Harshita-mindfire commented Sep 19, 2022

This PR aims to add a Copy As command. It is similar to Export pod command, with a predefined config.
Presently it supports two formats: JSON and markdown. The formatted note is copied to the clipboard.

TODO: copy as for a selection in note body

Dendron Extended PR Checklist

  • NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • [~] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

Extended

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Copy link
Contributor

@namjul namjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked great!

Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, and a small nit.

packages/pods-core/src/index.ts Show resolved Hide resolved
packages/plugin-core/src/commands/CopyAsCommand.ts Outdated Show resolved Hide resolved
@Harshita-mindfire Harshita-mindfire merged commit 4f77dfa into master Sep 23, 2022
@Harshita-mindfire Harshita-mindfire deleted the feat/copy-as-command branch September 23, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants