Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Schema Validator Page #2490

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft

feat: Schema Validator Page #2490

wants to merge 45 commits into from

Conversation

maxkrieger
Copy link

This PR will contribute the first portion of [[Graphical Schema Interface|proj.2022.graphical-schema-interface]]

Pull Request Checklist

Code

Basics

Extended

  • General
    • check whether code be simplified
    • check if similar function already exist in the codebase. if so, can it be re-used?
    • check if this change adversely impact performance
  • Operations
    • when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?
  • Architecture
    • check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

Instrumentation

Basics

  • if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

Tests

Basics

Extended

  • If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
  • CSS
    • display is correct for following dimensions
      • sm: screen ≥ 576px, eg. iphonex, (375x812)
      • lg: screen ≥ 992px
      • xxl: screen ≥ 1600px eg. mac (1600x900)
    • display is correct for following browsers (across the various dimensions)
      • safari
      • firefox
      • chrome

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop

Extended

  • is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -0,0 +1,5 @@
import { DendronProps } from "../types";

export default function DendronSchemaPage({}: DendronProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you get this to render?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add it to VALID_NAMES - will push soon!

@kevinslin
Copy link
Member

can you rebase off of master? we've had a lot of changes that made it in since this branch was created

@kevinslin
Copy link
Member

also, don't forget the CLA :)

@maxkrieger
Copy link
Author

Will do!

@maxkrieger maxkrieger changed the title feat: add initial schema page defn feat: Schema Validator Page May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants