Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs for deprecated Open Link command #648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hikchoi
Copy link
Contributor

@hikchoi hikchoi commented Sep 14, 2022

What does this PR do?

Remove docs for deprecated Open Link command

What issues does this PR fix or reference?

NOTE: Fixes will close the ticket after merging. Relates to: will leave the ticket open after merging.

Merge requirements satisfied

For more information, visit the Contributing Guide for Documentation

  • Check rendered output to ensure formatting is correct for renderings of wikilinks, note refs, tables, and images. Dendron: Show Preview can be used in your workspace to confirm the page renders as expected. Sometimes, Dendron: Reload Index needs to be ran if certain wikilinks aren't working as expected. (ignore this if contribution is made via the Edit this page on GitHub button from the published site)
  • If this PR includes any refactoring (renaming notes, renaming headers, etc.), make sure that these changes were done via Dendron Refactoring Commands. This will ensure that any other impacted areas of the documentation, that link to or embed modified notes (via note references), are automatically updated.

Verify GitHub Actions tests are passing, which can be seen in the Checks tab of the PR:

  • URL validator GitHub Action passes
  • Dendron site build GitHub Action passes

NOTE: If you are a new contributor, a maintainer will need to provide approval for GitHub Actions to run on your PRs.

Copy link
Contributor

@Harshita-mindfire Harshita-mindfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hikchoi can we update the base branch to merge as dev instead of master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants