Container Refactor #288
Merged
Container Refactor #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewasmer
force-pushed
the
container-refactor
branch
from
bd5158f
to
528d071
Compare
davewasmer
force-pushed
the
container-refactor
branch
from
528d071
to
a8084c4
Compare
|
This should be backwards compatible. Also note that I've left out injections for now - that may end up requiring a bigger, backwards-incompatible change. This lays the foundation for injections, but doesn't require/support them yet. |
davewasmer
force-pushed
the
container-refactor
branch
from
79d301b
to
3f76e12
Compare
The resolver and related refactor enables: 1. Lazy loading of app code, which is now the default. It doesn't preclude eager loading though, and future work could add an eager load option for production environments. 2. Customizable directory structures. This is generally not a good idea for the casual use case, but it's possible that some additional type of code asset might need different lookup rules (i.e. test files) 3. Cleaner addon / application loading. The application logger is now customizable by simply adding `app/logger.js` (as long as the interface matches). Same for the `app/router.js`. This also solves some outstanding issues: fixes #285, #284
… lookup app modules (router, logger) until after addons are constructed so that we can rely on addons to supply those
davewasmer
force-pushed
the
container-refactor
branch
from
3f76e12
to
d5af314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver and related refactor enables:
Lazy loading of app code, which is now the default. It doesn't preclude eager loading though, and future work could add an eager load option for production environments. This matches our long term goal - lazy load for faster dev and test environments, and eager load for production for smoother, more predictable performance.
Customizable directory structures. This is generally not a good idea for the casual use case, but it's possible that some additional type of code asset might need different lookup rules (i.e. test files)
Cleaner addon / application loading. The application logger is now customizable by simply adding
app/logger.js(as long as the interface matches). Same for theapp/router.js.This also solves some outstanding issues: fixes #285, #284