Skip to content

fix issues in Cookie interface #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvitcom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issues in Cookie interface #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions handlers.user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,11 @@ func performLogin(c *gin.Context) {
username := c.PostForm("username")
password := c.PostForm("password")

var sameSiteCookie http.SameSite;

// Check if the username/password combination is valid
if isUserValid(username, password) {
// If the username/password is valid set the token in a cookie
token := generateSessionToken()
c.SetCookie("token", token, 3600, "", "", sameSiteCookie, false, true)
c.SetCookie("token", token, 3600, "", "", false, true)
c.Set("is_logged_in", true)

render(c, gin.H{
Expand All @@ -52,10 +50,8 @@ func generateSessionToken() string {

func logout(c *gin.Context) {

var sameSiteCookie http.SameSite;

// Clear the cookie
c.SetCookie("token", "", -1, "", "", sameSiteCookie, false, true)
c.SetCookie("token", "", -1, "", "", false, true)

// Redirect to the home page
c.Redirect(http.StatusTemporaryRedirect, "/")
Expand All @@ -72,12 +68,10 @@ func register(c *gin.Context) {
username := c.PostForm("username")
password := c.PostForm("password")

var sameSiteCookie http.SameSite;

if _, err := registerNewUser(username, password); err == nil {
// If the user is created, set the token in a cookie and log the user in
token := generateSessionToken()
c.SetCookie("token", token, 3600, "", "", sameSiteCookie, false, true)
c.SetCookie("token", token, 3600, "", "", false, true)
c.Set("is_logged_in", true)

render(c, gin.H{
Expand Down