Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets.py download location #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ihnorton
Copy link
Contributor

@ihnorton ihnorton commented Mar 5, 2018

Fixes #42 (the last one doesn't exist though, even on the old server. maybe that's why the test is disabled?)

Fixes demianw#42 (the last one doesn't exist though, even on the old server. maybe that's why the test is disabled?)
@jcfr
Copy link

jcfr commented Mar 5, 2018

@ihnorton Thanks for updating the URLs.

Look like you forgot the one associated with wmql_2_uf.qry

xref https://discourse.slicer.org/t/retiring-midas-kitware-com-data-repository/2243/4?u=jcfr

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #43 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   45.06%   44.95%   -0.11%     
==========================================
  Files          27       26       -1     
  Lines        2543     2538       -5     
==========================================
- Hits         1146     1141       -5     
  Misses       1397     1397
Impacted Files Coverage Δ
tract_querier/tests/datasets.py 39.13% <ø> (ø) ⬆️
tract_querier/util.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f956c09...8901057. Read the comment docs.

@ihnorton
Copy link
Contributor Author

ihnorton commented Mar 5, 2018

Ah good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants