Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffi): Add DC_STR_CANT_DECRYPT_OUTGOING_MSGS define #5664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Jun 3, 2024

As @gerryfrancis said,

FYI, I have gotten this system message after I created new DC profiles (for testing), but the device has been the same since. Although I know what this is about, it might confuse other DC users in similar situations...

So maybe making less assumtions about what the user does wrong is better. Just in case, the previous discussion of this stock string: #5176 (comment)

@iequidoo iequidoo marked this pull request as ready for review June 3, 2024 18:53
@link2xt link2xt requested review from r10s and adbenitez June 4, 2024 15:01
@link2xt
Copy link
Collaborator

link2xt commented Jun 4, 2024

This looks good but if we merge this we should also change the string in the Android repo because it is the string that is actually used and gets translated. Core fallback is normally not used at all.

@r10s
Copy link
Member

r10s commented Jun 4, 2024

tbh, not sure if the new wording is better.

the "some outgoing messages" seems more vague than "each other's outgoing messages". and the wording adopts to rarer cases (as @gerryfrancis was using the same device during testing), however probably weakens the string for the majority of cases (user really setting up a second device wrongly).

all in all i found the old wording more on point and actionable ("to fix that")

but yeah, it is a minor one and if we think the rarer cases happen often enough outside artificial testing scenarios, we can go for it and i am also fine with it.

for translations: in fact, the string is not yet translated at all yet (what a luck!, so we can do changes without annoying translators :), also the corresponding define in deltachat.h is missing

@iequidoo iequidoo force-pushed the iequidoo/CantDecryptOutgoingMsgs branch from 0481d19 to 4dce996 Compare June 6, 2024 01:17
@iequidoo
Copy link
Collaborator Author

iequidoo commented Jun 6, 2024

I agree with @r10s that the existing phrasing is probably better for the most users, but just in case tried to improve it once more

@iequidoo iequidoo force-pushed the iequidoo/CantDecryptOutgoingMsgs branch from 954e59c to f428438 Compare June 6, 2024 01:34
@iequidoo iequidoo changed the title feat: Shorten CantDecryptOutgoingMsgs stock string feat(ffi): Add DC_STR_CANT_DECRYPT_OUTGOING_MSGS define Jun 6, 2024
@iequidoo iequidoo force-pushed the iequidoo/CantDecryptOutgoingMsgs branch from f428438 to 21c9c06 Compare June 6, 2024 01:38
@link2xt
Copy link
Collaborator

link2xt commented Jun 6, 2024

"Could not decrypt outgoing messages that may be from Delta Chat on your other device." can be read as "Could not decrypt ... on your other device."

So we have these options:

  • ⚠️ It seems you are using Delta Chat on multiple devices that cannot decrypt each other's outgoing messages. To fix this, on the older device use \"Settings / Add Second Device\" and follow the instructions. (original)
  • ⚠️ Could not decrypt some outgoing messages. If you are using Delta Chat on multiple devices, on the older device use \"Settings / Add Second Device\" and follow the instructions. (before force-push)
  • ⚠️ Could not decrypt outgoing messages that may be from Delta Chat on your other device. If so, to fix this, on the older device use \"Settings / Add Second Device\" and follow the instructions. (after force-push)

@iequidoo
Copy link
Collaborator Author

iequidoo commented Jun 6, 2024

"Could not decrypt outgoing messages that may be from Delta Chat on your other device." can be read as "Could not decrypt ... on your other device."

I don't think so, even Google Translate feels the difference (when translating to Spanish f.e.) if i put commas as follows:
⚠️ Could not decrypt outgoing messages, that may be from Delta Chat, on your other device. If so, to fix this, on the older device use \"Settings / Add Second Device\" and follow the instructions.
But another option is
⚠️ Could not decrypt outgoing messages that may be from your other device's Delta Chat. If so, to fix this, on the older device use \"Settings / Add Second Device\" and follow the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants