Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to pull in translations from weblate #3022

Closed
wants to merge 1 commit into from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented May 6, 2024

Closes #2990

@link2xt link2xt requested review from r10s and adbenitez May 6, 2024 15:59
Copy link

github-actions bot commented May 6, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt
Copy link
Contributor Author

link2xt commented May 6, 2024

Related PR where I pulled translations: #3021

@r10s
Copy link
Member

r10s commented May 6, 2024

thanks for the documentation!

however, as i am using RELEASE.md as a checklist (i am really going through that step by step on releases, reading through every step to not forget anything :) - i would prefer to have that shorter and easier - it is currently more steps than in-app-strings and offline-help together.

i suggest to create a dedicated ./scripts/pull-fdroid-metadata.sh with the following content:

git remote add weblate https://translate.codeberg.org/git/delta-chat/android-metadata/  # this prints an error when already added
git fetch weblate
git merge --no-ff weblate/main -m "Merge F-Droid metadata translations from Weblate"  # this prints "Already up to date" when all is in sync

and add that to RELEASE.md at step 3.

for the added "remote": i did not work with multiple remotes yet - "origin" is still the default? wondering if there is sth. to keep in mind ...

@link2xt link2xt marked this pull request as draft May 6, 2024 17:28
@link2xt
Copy link
Contributor Author

link2xt commented May 6, 2024

Maybe we switch to hosted weblate (#3024) and it will just open PRs from time to time automatically.

@r10s
Copy link
Member

r10s commented May 6, 2024

Maybe we switch to hosted weblate (#3024) and it will just open PRs from time to time automatically.

yes, maybe that's better. seems reasonable to do what is kind of default for translators. if that works out, we can also consider to move strings.xml there and see how it goes - maybe start with languages that are not present or badly translated on transifex, but that is nothing for the next weeks ;)

but for now, i would also be fine with one more step in RELEASE.md

@r10s
Copy link
Member

r10s commented Jul 30, 2024

Maybe we switch to hosted weblate (#3024) and it will just open PRs from time to time automatically.

i think, this is what happens meanwhile eg. at #3145 .
closing this PR for now.

btw, seems also Delta Chat was approved as an open source project; at least i do not see a warning any longer

@r10s r10s closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull metadata and changelog translations from weblate
2 participants