Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/merge from portal accurate #615

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

KevinRohlf
Copy link
Collaborator

Proposed Changes

  • merge features from accurate portal

@KevinRohlf KevinRohlf requested review from a team as code owners October 28, 2024 14:02
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mvg-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:44pm

content/site.json Show resolved Hide resolved
content/site.json Show resolved Hide resolved
address.config.js Outdated Show resolved Hide resolved
address.config.js Outdated Show resolved Hide resolved
content/publish/form.json Outdated Show resolved Hide resolved
src/pages/faucet.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@moritzkirstein moritzkirstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! we're almost done, only a few small change requests left to take care of 🙏

address.config.js Outdated Show resolved Hide resolved
chains.config.js Outdated Show resolved Hide resolved
content/site.json Outdated Show resolved Hide resolved
Comment on lines 22 to 25
.form > input {
border: var(--border-size-sm) solid var(--border-color);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): this looks like a design addition that was not intended

@moritzkirstein moritzkirstein merged commit a13b58d into development Oct 30, 2024
8 of 9 checks passed
@moritzkirstein moritzkirstein deleted the feat/merge-from-portal-accurate branch October 30, 2024 21:07
moritzkirstein pushed a commit that referenced this pull request Oct 30, 2024
* feat: merge accurate-portal

* fix: edit crash additionalInformation undefined

* fix: update faucet

* fix: update address.config.js, content, images, faucet and publish

* fix: deleted form input styling update
moritzkirstein pushed a commit that referenced this pull request Oct 31, 2024
* feat: merge accurate-portal

* fix: edit crash additionalInformation undefined

* fix: update faucet

* fix: update address.config.js, content, images, faucet and publish

* fix: deleted form input styling update
moritzkirstein pushed a commit that referenced this pull request Nov 11, 2024
* feat: merge accurate-portal

* fix: edit crash additionalInformation undefined

* fix: update faucet

* fix: update address.config.js, content, images, faucet and publish

* fix: deleted form input styling update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants