Merge pull request #527 from deltaDAO/development

fix: add checks if edit state tx was successful (#526)
deltaDAO · Mar 25, 2024 · e54272c · e54272c
2 parents ddab483 + d94a363
commit e54272c
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 17 deletions.
diff --git a/content/pages/editMetadata.json b/content/pages/editMetadata.json
@@ -2,6 +2,7 @@
   "form": {
     "success": "🎉 Successfully updated. 🎉\n\nUpdates might not show up right away on your asset. In this case, wait some seconds and reload your asset details page in your browser.",
     "error": "Updating DDO failed.",
+    "stateError": "Updating asset state failed.",
     "data": [
       {
         "name": "name",

diff --git a/src/components/Asset/Edit/EditMetadata.tsx b/src/components/Asset/Edit/EditMetadata.tsx
@@ -212,35 +212,45 @@ export default function Edit({
       //   newAbortController()
       // )
 
-      console.log({ state: values.assetState, assetState })
+      if (!setMetadataTx) {
+        setError(content.form.error)
+        LoggerInstance.error(content.form.error)
+        return
+      }
+      await setMetadataTx.wait()
+
+      LoggerInstance.log('[edit] asset states', {
+        state: values.assetState,
+        assetState
+      })
       if (values.assetState !== assetState) {
         const nft = new Nft(signer)
 
-        await nft.setMetadataState(
+        const setMetadataStateTx = await nft.setMetadataState(
           asset?.nftAddress,
           accountId,
           assetStateToNumber(values.assetState)
         )
+        if (!setMetadataStateTx) {
+          setError(content.form.stateError)
+          LoggerInstance.error(content.form.stateError)
+          return
+        }
+        await setMetadataStateTx.wait()
       }
 
       LoggerInstance.log('[edit] setMetadata result', setMetadataTx)
 
-      if (!setMetadataTx) {
-        setError(content.form.error)
-        LoggerInstance.error(content.form.error)
-        return
-      } else {
-        await setMetadataTx.wait()
-        if (asset.accessDetails.type === 'free') {
-          const tx = await setMinterToDispenser(
-            signer,
-            asset?.accessDetails?.datatoken?.address,
-            accountId,
-            setError
-          )
-          if (!tx) return
-        }
+      if (asset.accessDetails.type === 'free') {
+        const tx = await setMinterToDispenser(
+          signer,
+          asset?.accessDetails?.datatoken?.address,
+          accountId,
+          setError
+        )
+        if (!tx) return
       }
+
       // Edit succeeded
       setSuccess(content.form.success)
       resetForm()