[Kernel] Fixed potential float -> double casting issue and aligned IN expression with comparator "=" implementation #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Signed-off-by: isaiah mowbray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #5227
Investigated float-to-double precision issue in ImplicitCastExpression
Refactor validateAndTransform method to use implicit casting
Simplify value comparison logic in InColumnVector
How was this patch tested?
New UTs and validated existing UTs
Does this PR introduce any user-facing changes?
No