[Kernel connector] Handle unsupported data types in kernel-spark connector #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asl3
changed the title
There was a problem hiding this comment.
shall we rename spark-variant-checkpoint to just variant?
| assertThrows( | ||
| RuntimeException.class, | ||
| () -> { | ||
| spark.sql("SELECT * FROM `dsv2`.`delta`.`" + tablePath + "`").collect(); |
There was a problem hiding this comment.
The error comes from:
at io.delta.kernel.spark.utils.SchemaUtils.convertKernelDataTypeToSparkDataType(SchemaUtils.java:116)
at io.delta.kernel.spark.utils.SchemaUtils.convertKernelSchemaToSparkSchema(SchemaUtils.java:60)
It seesm that it is already handled in SchemaUtils. In such a case, we can just remove all the code changes in SparkTable.java
There was a problem hiding this comment.
In the future, when getting table schema from Unity catalog, we can check whether the UC schema is supported in Kernel. For example, the Time type is not supported yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Allowlist for kernel-Spark connector supported schema data types.
We now fail with a more descriptive error message when schema data types are unsupported:
How was this patch tested?
Added a new golden table file, variant-spark-checkpoint
Does this PR introduce any user-facing changes?
Yes, updates the user-facing error message to be more descriptive