[Kernel][Metrics][PR#1] Adds initial interfaces and a Timer class #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
allisonport-db
changed the title
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/Timer.java
Outdated
Show resolved
Hide resolved
| import java.util.UUID; | ||
|
|
||
| /** Defines the common fields that are shared by reports for Delta operations */ | ||
| public interface DeltaOperationReport extends MetricsReport { |
There was a problem hiding this comment.
Will MetricsReporter::report ever be called with a different type of MetricsReport that is not a DeltaOperationReport?
There was a problem hiding this comment.
Yes in the future possibly. We want MetricsReport to be completely generic so we can push anything we want as part of the interface.
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/Timer.java
Show resolved
Hide resolved
allisonport-db
force-pushed
the
metrics-1
branch
from
232933e to
e64ae0b
Compare
This was referenced Nov 27, 2024
scottsand-db
approved these changes
Dec 3, 2024
kernel/kernel-api/src/test/scala/io/delta/kernel/metrics/MetricsUtilsSuite.scala
Outdated
Show resolved
Hide resolved
allisonport-db
added a commit
to allisonport-db/delta
that referenced
this pull request
Dec 11, 2024
…lass (delta-io#3902)" This reverts commit 82c2f64.
allisonport-db
added a commit
to allisonport-db/delta
that referenced
this pull request
Dec 11, 2024
…lass (delta-io#3902)" This reverts commit 82c2f64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds the initial interfaces for #3905 as well as a
Timerclass that will be used in follow-up PRs.How was this patch tested?
Just interface changes.
Does this PR introduce any user-facing changes?
No.