Set compression levels to upstream defaults #476
Merged
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the compression defaults are maxed out to maximize storage gains (except for xz which is set to default?), at the cost of taking minutes instead of seconds to compress.
There is previous conversation about this comparing zstd gains at max vs minimum - #455
@skwerlman made a PR that that made the values configurable - #456
This PR changes this configuration to upstream defaults, as suggested in the above discussion.
The suggestion also considered dropping the parameters altogether to just always adapt upstream defaults - it should be more user friendly for those that are trying to modify the configuration to have a set example.
This is likely to break setups where people are putting the modules on an undersized ESP (notably, when people reuse the 100MiB Windows ESP for /boot), so bumping the filesizes by a couple megabytes could tip the size over the max.
Such people can either fix their ESP size, or more simply configure dkms to use the old values that sacrifice speed for space savings.