Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case improvement #71

Merged
merged 3 commits into from
May 10, 2024

Conversation

ThanosTsiamis
Copy link
Contributor

Reduces the number of test cases by using the parametrized decorator provided by pytest.

Tests are no longer part of the class TestAlgorithms() as this class is not used anywhere and pytest has no way to pass in the parameter.

…provided by pytest.

Tests are no longer part of the class TestAlgorithms() as this class is not used anywhere and pytest has no way to pass in the parameter.
@kPsarakis
Copy link
Member

Thanks for the PR @ThanosTsiamis!

Could you check why the CI is failing after your changes and address that?

@ThanosTsiamis
Copy link
Contributor Author

Hey @kPsarakis !
Apologies for the oversight! Forgot to add the pytest package to the requirements.txt file. I hope it works now. If not I'll turn it into a WIP and develop it on my own

@ThanosTsiamis ThanosTsiamis changed the title Test case improvement [WIP]Test case improvement May 8, 2024
@ThanosTsiamis ThanosTsiamis reopened this May 8, 2024
@kPsarakis
Copy link
Member

@ThanosTsiamis The CI passes now. Is this still WIP, or is it ok to merge?

@kPsarakis kPsarakis added the nice to have low importance / nice to have improvement label May 9, 2024
@kPsarakis kPsarakis self-requested a review May 9, 2024 13:26
@ThanosTsiamis ThanosTsiamis changed the title [WIP]Test case improvement Test case improvement May 10, 2024
@ThanosTsiamis
Copy link
Contributor Author

Hi @kPsarakis.
Please review it at your earliest convenience!
Cheers!

Copy link
Member

@kPsarakis kPsarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@kPsarakis kPsarakis merged commit ee34c44 into delftdata:master May 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have low importance / nice to have improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants