Skip to content

Commit

Permalink
Merge branch 'master' into fix/preactjs#2644
Browse files Browse the repository at this point in the history
  • Loading branch information
deleonio committed Sep 29, 2020
2 parents 8367c16 + 8603d70 commit 8265ed8
Show file tree
Hide file tree
Showing 89 changed files with 18,495 additions and 17,441 deletions.
4 changes: 3 additions & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
👋 Hi there! Thanks for taking the time to open an issue.
ׁ
Here's a guide to getting your issue resolved quickly:
🗣 For help with Preact, ask on Slack: https://preact-slack.now.sh
❓ Did you check that you're on the latest version of Preact?
🗣 For help with Preact, ask on Slack: https://chat.preactjs.com/
✨ Check for existing StackOverflow solutions: https://stackoverflow.com/search?q=preact
📚 Check out our docs - for Preact 10: https://preactjs.com/guide/v10/getting-started
🔎 Check if there's already an issue for your problem
Expand Down
111 changes: 85 additions & 26 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- uses: actions/setup-node@v1
with:
node-version: '14.x'
Expand Down Expand Up @@ -49,90 +47,151 @@ jobs:
# Use --ignore-scripts here to avoid re-building again before pack
run: |
npm pack --ignore-scripts
tar -xzf preact-*.tgz
mv preact-*.tgz preact.tgz
tar -xzf preact.tgz
- name: Upload build output
uses: actions/upload-artifact@v2
with:
name: build-output
path: package/
- name: Upload npm package
uses: actions/upload-artifact@v2
with:
name: npm-package
path: preact.tgz
- name: Initialize Tachometer Results Report
uses: andrewiggins/tachometer-reporter-action@v2
with:
initialize: true

bench_text_update:
name: Bench text_update
runs-on: windows-latest
runs-on: ubuntu-latest
needs: build_test
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
fetch-depth: 1
node-version: '14.x'
- uses: actions/download-artifact@v2
with:
name: build-output
- uses: andrewiggins/download-base-artifact@v1
with:
artifact: npm-package
required: false
- name: install & build
run: |
cd benches
npm ci
- name: bench
run: |
export CHROMEDRIVER_FILEPATH=$(which chromedriver)
cd benches
npm run bench text_update.html
- uses: andrewiggins/tachometer-reporter-action@v2
with:
path: benches/results/text_update.json
report-id: text_update
base-bench-name: preact-master
pr-bench-name: preact-local

bench_many_updates:
name: Bench many_updates
runs-on: ubuntu-latest
needs: build_test
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '14.x'
- uses: actions/download-artifact@v2
with:
name: build-output
- uses: andrewiggins/download-base-artifact@v1
with:
artifact: npm-package
required: false
- name: install & build
env:
# Skip downloading Firefox driver until we bench against it
GECKODRIVER_SKIP_DOWNLOAD: 'true'
run: |
$env:CHROMEDRIVER_FILEPATH=(Join-Path $env:CHROMEWEBDRIVER chromedriver.exe)
cd benches
npm ci
- name: bench
run: |
export CHROMEDRIVER_FILEPATH=$(which chromedriver)
cd benches
npm run bench text_update.html
npm run bench many_updates.html
- uses: andrewiggins/tachometer-reporter-action@v2
with:
path: benches/results/many_updates.json
report-id: many_updates
base-bench-name: preact-master
pr-bench-name: preact-local

bench_02_replace1k:
name: Bench 02_replace1k
runs-on: windows-latest
runs-on: ubuntu-latest
needs: build_test
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
fetch-depth: 1
node-version: '14.x'
- uses: actions/download-artifact@v2
with:
name: build-output
- uses: actions/setup-node@v1
- uses: andrewiggins/download-base-artifact@v1
with:
node-version: '14.x'
artifact: npm-package
required: false
- name: install & build
env:
# Skip downloading Firefox driver until we bench against it
GECKODRIVER_SKIP_DOWNLOAD: 'true'
run: |
$env:CHROMEDRIVER_FILEPATH=(Join-Path $env:CHROMEWEBDRIVER chromedriver.exe)
cd benches
npm ci
- name: bench
run: |
export CHROMEDRIVER_FILEPATH=$(which chromedriver)
cd benches
npm run bench 02_replace1k.html
- uses: andrewiggins/tachometer-reporter-action@v2
with:
path: benches/results/02_replace1k.json
report-id: 02_replace1k
base-bench-name: preact-master
pr-bench-name: preact-local

bench_03_update10th1k_x16:
name: Bench 03_update10th1k_x16
runs-on: windows-latest
runs-on: ubuntu-latest
needs: build_test
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
fetch-depth: 1
node-version: '14.x'
- uses: actions/download-artifact@v2
with:
name: build-output
- uses: actions/setup-node@v1
- uses: andrewiggins/download-base-artifact@v1
with:
node-version: '14.x'
artifact: npm-package
required: false
- name: install & build
env:
# Skip downloading Firefox driver until we bench against it
GECKODRIVER_SKIP_DOWNLOAD: 'true'
run: |
$env:CHROMEDRIVER_FILEPATH=(Join-Path $env:CHROMEWEBDRIVER chromedriver.exe)
cd benches
npm ci
- name: bench
run: |
export CHROMEDRIVER_FILEPATH=$(which chromedriver)
cd benches
npm run bench 03_update10th1k_x16.html
- uses: andrewiggins/tachometer-reporter-action@v2
with:
path: benches/results/03_update10th1k_x16.json
report-id: 03_update10th1k_x16
base-bench-name: preact-master
pr-bench-name: preact-local
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ For us a [codesandbox](https://codesandbox.io/) says more than a 1000 words :tad

## I have more questions on how to contribute to Preact. How can I reach you?

We closely watch our issues and have a pretty active [Slack workspace](https://preact-slack.now.sh/). Nearly all our communication happens via these two forms of communication.
We closely watch our issues and have a pretty active [Slack workspace](https://chat.preactjs.com/). Nearly all our communication happens via these two forms of communication.

## Releasing Preact (Maintainers only)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<td>

[![npm](https://img.shields.io/npm/v/preact.svg)](http://npm.im/preact)
[![Preact Slack Community](https://preact-slack.now.sh/badge.svg)](https://preact-slack.now.sh)
[![Preact Slack Community](https://preact-slack.now.sh/badge.svg)](https://chat.preactjs.com)
[![OpenCollective Backers](https://opencollective.com/preact/backers/badge.svg)](#backers)
[![OpenCollective Sponsors](https://opencollective.com/preact/sponsors/badge.svg)](#sponsors)

Expand Down
4 changes: 3 additions & 1 deletion benches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ This directory contains benchmarks for Preact, run using the [`polymer/tachomete

## Getting Started

To run and debug benches use the following npm scripts:
To run benchmark suite, use `npm bench`.

To debug benches locally, use `npm start`.

### bench

Expand Down
Loading

0 comments on commit 8265ed8

Please sign in to comment.