Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create links and make them beautiful #146

Merged
merged 17 commits into from
Sep 19, 2024
Merged

Conversation

wirednkod
Copy link
Member

closes #139


Submission checklist:

Layout

  • Create link icon next to each title

@wirednkod wirednkod requested a review from Tbaut as a code owner September 16, 2024 16:26
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024

Deploying delegit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ae4c74
Status: ✅  Deploy successful!
Preview URL: https://31745d31.delegit.pages.dev
Branch Preview URL: https://nik-make-link-urls-beautiful.delegit.pages.dev

View logs

@wirednkod wirednkod mentioned this pull request Sep 16, 2024
2 tasks
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really cool functionality! I've a couple suggestions here and there

src/components/DelegateCard.tsx Outdated Show resolved Hide resolved
src/pages/Delegate/index.tsx Outdated Show resolved Hide resolved
src/pages/Delegate/index.tsx Outdated Show resolved Hide resolved
src/pages/Delegate/index.tsx Outdated Show resolved Hide resolved
src/pages/Delegate/index.tsx Outdated Show resolved Hide resolved
src/lib/utils.ts Outdated Show resolved Hide resolved
src/Content.tsx Outdated Show resolved Hide resolved
@Tbaut
Copy link
Contributor

Tbaut commented Sep 17, 2024

I'm not happy with the amount of weird logic here, so I pushed a PR to have it all in a component that's made specifically for this. Please let me know what you think #152 You can merge, and then we merge this one.

@wirednkod wirednkod marked this pull request as draft September 18, 2024 07:31
@wirednkod
Copy link
Member Author

After Merging #152 this stopped working. Will have to fix that

@Tbaut
Copy link
Contributor

Tbaut commented Sep 18, 2024

I can check it no worries, it worked in my tests, on my branch. Some small things went through in between

…/dashboard into nik-make-link-urls-beautiful
@wirednkod
Copy link
Member Author

I can check it no worries, it worked in my tests, on my branch. Some small things went through in between

Dont worry. I look at it

@wirednkod wirednkod marked this pull request as ready for review September 18, 2024 12:07
@wirednkod wirednkod requested a review from Tbaut September 18, 2024 12:08
@wirednkod
Copy link
Member Author

Works fine. Lets merge this :)

@Tbaut
Copy link
Contributor

Tbaut commented Sep 18, 2024

There's something not working well with the way we fetch delegates. And where getDelegateByAddress returns undefined when it shouldn't. Maybe with the JSON. I'm investigating.

This happens particularly when:

  • you have Polkadot set as default (in your local storage)
  • you paste a kusama network name

@Tbaut
Copy link
Contributor

Tbaut commented Sep 18, 2024

Looks ok now, I've been testing heavily, please do as well if you can.

src/components/RedirectByName.tsx Show resolved Hide resolved
src/components/RedirectByName.tsx Show resolved Hide resolved
src/components/RedirectByName.tsx Show resolved Hide resolved
src/contexts/DelegatesContext.tsx Show resolved Hide resolved
@wirednkod
Copy link
Member Author

Then we are good to go I guess. Lets merge this baby

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Tbaut Tbaut merged commit 228fc48 into main Sep 19, 2024
3 checks passed
@Tbaut Tbaut deleted the nik-make-link-urls-beautiful branch September 19, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make links cleaner
2 participants