-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create links and make them beautiful #146
Conversation
Deploying delegit with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a really cool functionality! I've a couple suggestions here and there
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
I'm not happy with the amount of weird logic here, so I pushed a PR to have it all in a component that's made specifically for this. Please let me know what you think #152 You can merge, and then we merge this one. |
After Merging #152 this stopped working. Will have to fix that |
I can check it no worries, it worked in my tests, on my branch. Some small things went through in between |
…/dashboard into nik-make-link-urls-beautiful
Dont worry. I look at it |
Works fine. Lets merge this :) |
There's something not working well with the way we fetch delegates. And where This happens particularly when:
|
Looks ok now, I've been testing heavily, please do as well if you can. |
Then we are good to go I guess. Lets merge this baby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
closes #139
Submission checklist:
Layout