Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tst/metadata function #75

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Tst/metadata function #75

merged 10 commits into from
Mar 18, 2022

Conversation

thygesteffensen
Copy link
Member

No description provided.

According to the documentation the parameters must be string, but everything works in PA
Function Definition can be added to 'group' functions together to make it easier to write expressions with a lot of redundant function calls

Resolves #59
@thygesteffensen thygesteffensen self-assigned this Feb 28, 2022
@thygesteffensen thygesteffensen changed the base branch from main to dev February 28, 2022 11:22
@thygesteffensen thygesteffensen linked an issue Feb 28, 2022 that may be closed by this pull request
Copy link
Member

@pksorensen pksorensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smalll questions / improvments, but general design is good. Merge or update based on comments :)

ExpressionEngine/FlowRunnerDependencyExtension.cs Outdated Show resolved Hide resolved
ExpressionEngine/FunctionDefinition.cs Outdated Show resolved Hide resolved
ExpressionEngine/IFunctionDefinition.cs Outdated Show resolved Hide resolved
@thygesteffensen thygesteffensen merged commit 55c27a2 into dev Mar 18, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thygesteffensen thygesteffensen deleted the tst/metadata-function branch March 18, 2022 14:18
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Function Expression Defintions
2 participants