-
Notifications
You must be signed in to change notification settings - Fork 0
General Update: FMOD 2.03.09 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| local function update_attributes(attr, dt, new_position) | ||
| if new_position.x ~= new_position.x or attr.position.x ~= attr.position.x then | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason,nan vector errors were popping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please add which version of FMOD this extension is using in the readme? Let's add it as a GitHub "shield badge". Example:
https://github.com/defold/extension-steam/blob/master/README.md
Android has been updated to 2.03.09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: What about wasm_pthread-web support? In case if FMOD doesn't support pthread version of libraries for emscripten than we should add "stub" implementation for wasm_pthread-web like here
https://github.com/defold/extension-photon-realtime/blob/master/realtime/src/realtime.cpp#L1256-L1279
fmod/ext.manifest
Outdated
| js-web: | ||
| context: | ||
| libs: ["fmodbridge", "fmodstudio"] | ||
| emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\"]"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess here should be getValue and setValue also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree we should have it there
Test evidence shared
* 7 - Update macOS and iOS To 2.03.09 * 7 - commit libfmodbridge * 7 - new lines
* 12 - Readme 2.02.05 Is Out Of Date * 12 - switch to png banner * 12 - rm unused logo
docker-composein favor ofdocker composeFMOD 2.02 is out of date #6
HTML5: Module.cwrap is not a function #2