Modify validity check + clean up creds #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishsriv
reviewed
Aug 13, 2024
translate_sql_dialect.py
Outdated
| from tqdm import tqdm | ||
| from eval.eval import get_all_minimal_queries | ||
| import os | ||
|
|
||
| tqdm.pandas() | ||
|
|
||
| dataset_file = ( | ||
| "data/instruct_advanced_postgres.csv" # Postgres dataset file to translate | ||
| "data/instruct_advanced_postgresTEST.csv" # Postgres dataset file to translate |
There was a problem hiding this comment.
thanks! i'll revert to the original
rishsriv
approved these changes
Aug 13, 2024
wongjingping
approved these changes
Aug 13, 2024
data/instruct_advanced_sqlite.csv
Outdated
| @@ -54,7 +54,7 @@ Last 30 days = DATE('now', '-30 days') to DATE('now') | |||
| PMSPS = per month salesperson signups | |||
| To get the total sales amount per salesperson, join the salespersons and sales tables, group by salesperson, and sum the sale_price. Always order results with NULLS last. | |||
| Truncate date to week for aggregation." | |||
| car_dealership,sqlite,instructions_cte_join,"WITH recent_sales AS (SELECT sp.id, sp.first_name, sp.last_name, COUNT(s.id) AS num_sales FROM salespersons AS sp LEFT JOIN sales AS s ON sp.id = s.salesperson_id WHERE s.sale_date >= DATE('now', '-30 days') GROUP BY sp.id) SELECT id, first_name, last_name, num_sales FROM recent_sales ORDER BY num_sales DESC;WITH recent_sales AS (SELECT sp.id, sp.first_name, sp.last_name, COUNT(s.id) AS num_sales FROM salespersons AS sp LEFT JOIN sales AS s ON sp.id = s.salesperson_id AND s.sale_date >= DATE('now', '-30 days') GROUP BY sp.id, sp.first_name, sp.last_name) SELECT id, first_name, last_name, num_sales FROM recent_sales ORDER BY num_sales DESC;","How many sales did each salesperson make in the past 30 days, inclusive of today's date? Return their ID, first name, last name and number of sales made, ordered from most to least sales.","To get the number of sales made by each salesperson in the past 30 days, join the salespersons and sales tables and filter for sales in the last 30 days.","When using car makes, model names, engine_type, and vin_number, ensure matching is case-insensitive and allows for partial matches using LIKE with wildcards. | |||
| car_dealership,sqlite,instructions_cte_join,"WITH recent_sales AS (SELECT sp.id, sp.first_name, sp.last_name, COUNT(s.id) AS num_sales FROM salespersons AS sp LEFT JOIN sales AS s ON sp.id = s.salesperson_id AND s.sale_date >= DATE('now', '-30 days') GROUP BY sp.id) SELECT id, first_name, last_name, num_sales FROM recent_sales ORDER BY num_sales DESC;","How many sales did each salesperson make in the past 30 days, inclusive of today's date? Return their ID, first name, last name and number of sales made, ordered from most to least sales.","To get the number of sales made by each salesperson in the past 30 days, join the salespersons and sales tables and filter for sales in the last 30 days.","When using car makes, model names, engine_type, and vin_number, ensure matching is case-insensitive and allows for partial matches using LIKE with wildcards. | |||
There was a problem hiding this comment.
Should it be GROUP BY sp.id, sp.first_name, sp.last_name) instead of GROUP BY sp.id)? Since we're selecting 3 columns
There was a problem hiding this comment.
Eh sorry i made a mistake. Shouldn't have removed the original because it provided an alternative where zero counts were not included.
On the grouping, I found just grouping by id producing the exact same results so I thought the other grouping cols was redundant. Is there a fundamental difference in meaning that I'm missing?
There was a problem hiding this comment.
Answering my own question: Ohh it's cos of postgres' flexi rules that it still works with grouping only by id. Should be better practice to add all selected cols in GROUP BY. Lemme revert to original!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialects.pyto always refer to db_creds_all inutils.creds