Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeprStore, K8s Fluent API & Watch Action #180

Merged
merged 124 commits into from
Oct 2, 2023
Merged

PeprStore, K8s Fluent API & Watch Action #180

merged 124 commits into from
Oct 2, 2023

Conversation

jeff-mccoy
Copy link
Member

@jeff-mccoy jeff-mccoy commented Jul 7, 2023 •
edited
Loading

Fixes #173
Fixes #49
Fixes #156
Fixes #139

  • Introduce new Watch action for observing resource events outside of the admission controller lifecycle
  • Introduces Pepr Store for lightweight key-value stores persistence
  • Introduces new K8s(kind.<Name>) fluent api from kubernetes-fluent-client
  • moves node-fetch wrapper & model to GVK mapping to kubernetes-fluent-client
  • Moves back to arrow functions vs binds due to complexities with Pepr Store binding sequence
  • Add higher test coverage around core library code
  • Leverage SSA for deploying K8s components in journey tests and npx pepr deploy
  • Add internal destroyModule() for purging a pepr module from a cluster

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2023
View reviewed changes
hack/e2e.test.mjs Fixed Show fixed Hide fixed
jeff-mccoy and others added 17 commits August 1, 2023 01:42
@jeff-mccoy
leader election -> dedicated pod
e455ff8
@jeff-mccoy
Add store subscribe
d5a316f
@jeff-mccoy
watcher statefulset -> deployment + more webhook reorg
ca764a4
@jeff-mccoy
Merge branch 'main' into shifting-sands
d481d31
@jeff-mccoy
conditionally generate the watch deployment
a1de123
@jeff-mccoy
pass errors from store write operations
d374163
@jeff-mccoy
introduce debounced/throttled read/write sync store + onready handler
26f64fd
@jeff-mccoy
wip crd madness
855bf01
@jeff-mccoy
Merge branch 'main' into shifting-sands
51cae98
@jeff-mccoy
Merge remote-tracking branch 'origin/shifting-sands' into shifting-sands
8eda32e
@jeff-mccoy
wip: move to Kube() api + PeprStore CRD
7175435
@jeff-mccoy
add jitter for controller store creation
bb91655
@jeff-mccoy
continue cleanup rbac/raw api
e2c614b
@jeff-mccoy
update e2e to match capability log changes
d623dd8
@jeff-mccoy
add readiness probes to wait for pepr store
d350d2f
@jeff-mccoy
Merge branch 'main' into shifting-sands
02bdb50
@jeff-mccoy
simplify fluent k8s fluent interfaces
f9597fa
Barry Waldbaum and others added 2 commits September 27, 2023 11:57
@Noxsios
Update README.md
9572c8f 
Co-authored-by: razzle <[email protected]>
@cmwylie19
Update docs/actions.md
da99d56 
Co-authored-by: Case Wylie <[email protected]>
btlghrants
btlghrants reviewed Sep 27, 2023
View reviewed changes
docs/store.md Outdated Show resolved Hide resolved
btlghrants
btlghrants reviewed Sep 27, 2023
View reviewed changes
docs/store.md Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy
Copy link
Member Author

Store.setItem("tenantGateway", "istio-system/tenant"); Store.getItem("tenantGateway")

produces nothing. Store.onReady happens after the controller starts, will expand testing to Mutate/Validate. Right now the Store not usable (at least with Watch)

right we brought that up yesterday, working that fix rn. Mutate/Validate should work, but you can't getItems until the store is ready--but today it doesnt throw an error.

@jeff-mccoy @btlghrants
Update docs/store.md
2d06b29 
Co-authored-by: Barrett <[email protected]>
jeff-mccoy and others added 2 commits September 27, 2023 14:12
btlghrants
btlghrants previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any red flags so let's do it, wee!

@jeff-mccoy jeff-mccoy requested a review from bdw617 October 1, 2023 15:47
cmwylie19
cmwylie19 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy jeff-mccoy dismissed bdw617’s stale review October 2, 2023 14:05

this was resolved

bdw617
bdw617 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@bdw617 bdw617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with caveats

btlghrants
btlghrants approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeff-mccoy jeff-mccoy merged commit 15cd74a into main Oct 2, 2023
9 checks passed
@jeff-mccoy jeff-mccoy deleted the shifting-sands branch October 2, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios left review comments

@cmwylie19 cmwylie19 cmwylie19 approved these changes

@bdw617 bdw617 bdw617 approved these changes

@btlghrants btlghrants btlghrants approved these changes

@rjferguson21 rjferguson21 Awaiting requested review from rjferguson21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@jeff-mccoy @cmwylie19 @bdw617 @Noxsios @btlghrants