This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Updated bbcode.js #189
Open
Updated bbcode.js #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PM, if you have some message with the [ code ] tag, it will break all the [ spoilers ] tags and they won't open when clicking on "Show spoiler" This problem is because of the first line of the function I deleted If the code find any 'pre.bbcode_code_body', it breaks the whole code, messing spoiler and youtube tags
|
To be a bit more specific: highlight.js is no longer included in extra_XXX.js, but there is still a hljs reference in the file. A [code] block in the source results in evaluation of hljs, which fails and stops the rest of the code from executing, breaking spoiler tags, but also previews and more. |
|
A better solution would be to check if hljs is defined within the each loop - or to include highlight.js as @dloser suggests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PM, if you have some message with the [ code ] tag, it will break all the [ spoilers ] tags and they won't open when clicking on "Show spoiler"
This problem is because of the first line of the function I deleted
If the code find any 'pre.bbcode_code_body', it breaks the whole code, messing spoiler and youtube tags