This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
Support query (and webpack 2) #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| babel: { | ||
| presets: ['es2015', 'stage-0', 'react'] | ||
| } | ||
| }, | ||
| … | ||
| module: { | ||
| preLoaders: [ |
There was a problem hiding this comment.
preLoaders should be replaced with rules, for an accurate documentation using webpack 2
README.md
Outdated
| @@ -90,13 +79,23 @@ config.set({ | |||
| path.resolve('src/components/'), | |||
| path.resolve('node_modules/') | |||
| ], | |||
| loader: 'babel' | |||
| loader: 'babel', | |||
There was a problem hiding this comment.
should be updated to babel-loader
|
I just use this pull request in my setup with webpack2... It seems working :) |
|
@dianadumbravean Fixed README |
|
there is no need to use isparta anymore, see https://github.com/deepsweet/istanbul-instrumenter-loader. this one is deprecated and no longer maintained. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first of all thanks for the loader, been serving me for quite some time 👍 .
As of Webpack 2 adding properties to the main config is disallowed. Loaders are required to receive their config via queries. This pull request also solves issue #20 and the non existing issue which is to support webpack 2.
Already tested and works fine on my repo.
Thanks in advance, unimonkiez