Enable grad scaler for ZeRO-0 + torch.autocast path #7619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Tanaka <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
tohtana
changed the title
Signed-off-by: Masahiro Tanaka <[email protected]>
sfc-gh-truwase
approved these changes
Oct 4, 2025
Liangliang-Ma
pushed a commit
to Liangliang-Ma/DeepSpeed
that referenced
this pull request
Oct 13, 2025
Currently, the DeepSpeed engine does not enable the grad scaler for the ZeRO-0 and `torch.autocast` path, even when dtype is set to `fp16`. This leads to errors in tests when we replace our hard-coded tolerances with PyTorch’s [standard tolerances](https://docs.pytorch.org/docs/stable/testing.html#torch.testing.assert_close) (Thank you @stas00 for you suggestion regarding the previous PR). This PR enables the grad scaler for this path to improve accuracy, and refactors the tests to simplify validation by using `torch.testing.assert_close`. The tests now rely on PyTorch’s standard (and stricter) tolerances, and they still pass. --------- Signed-off-by: Masahiro Tanaka <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Signed-off-by: Ma, Liangliang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the DeepSpeed engine does not enable the grad scaler for the ZeRO-0 and
torch.autocastpath, even when dtype is set tofp16. This leads to errors in tests when we replace our hard-coded tolerances with PyTorch’s standard tolerances (Thank you @stas00 for you suggestion regarding the previous PR).This PR enables the grad scaler for this path to improve accuracy, and refactors the tests to simplify validation by using
torch.testing.assert_close. The tests now rely on PyTorch’s standard (and stricter) tolerances, and they still pass.