-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Create COMMITTERS_RESPONSIBILITY.md #7300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PKUWZP
wants to merge
6
commits into
master
Choose a base branch
from
zhipwang_dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0a44543
Create COMMITTERS_RESPONSIBILITY.md
PKUWZP 8f5c8b3
Update COMMITTERS.md
PKUWZP 0060bfa
Update COMMITTERS.md
PKUWZP 1382769
Update COMMITTERS.md
PKUWZP 7e907a2
Merge branch 'master' into zhipwang_dev
sfc-gh-truwase aaf1b0c
Merge branch 'master' into zhipwang_dev
tjruwase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Responsibilities of the DeepSpeed Committers | ||
|
||
The Committer of the DeepSpeed project will be responsible for overseeing the project, with particular responsibilities described as following: | ||
|
||
### Reviewing Pull Requests, Issues and Proposals (RFCs) in a timely manner, and help maintain the necessary code quality for all contributions. | ||
|
||
Committers are responsible for maintaining the quality of the codebase and ensuring that contributions meet the project's standards. | ||
More specifically, this includes timely reviewing the incoming pull requests (PR), issues and proposals (RFCs), and routing the PRs to | ||
the right owners for high quality reviews. Committers are also responsible for providing constructive feedback to contributors, | ||
helping to maintain the code quality for all code merges/contributions. | ||
|
||
|
||
### Setting up the long-term technical roadmaps and strategic vision for the DeepSpeed project. | ||
|
||
Given the rapid development of the AI and ML ecosystem, the committers are responsible for periodically reviewing the unique value proposition | ||
of the DeepSpeed project, and hold discussions internally to establish the long-term technical roadmaps for the project development. | ||
Also the committers are responsible for setting up the strategic vision, which includes building and growing the contributor community, | ||
and improving adoption and compatibility in the fast-evolving AI ecosystem. | ||
|
||
### Leading the collaboration to work with other open source or open standards communities. | ||
|
||
The committers are responsible for coordinating and collaborating with other open source or open standards communities to improve | ||
DeepSpeed's compatibility and interoperability with other projects. The committers are also responsible for holding discussions | ||
internally to reach consensus on what open source projects to collaborate with, and how to position DeepSpeed in the open source ecosystem. | ||
|
||
### Organizing the DeepSpeed Community Meetups, Marketing and Events etc. Maintaining the DeepSpeed Website and monitoring the Social Media Platforms. | ||
|
||
The committers are responsible for organizing the DeepSpeed community meetups, Marketing and Events etc. They are also responsible | ||
for maintaining/updating the DeepSpeed website, and monitor/steering the DeepSpeed social media platforms to maintain the healthy culture | ||
of the discussions. | ||
|
||
### Establishing community norms, workflows, issuing releases, and security issue reporting policies. | ||
|
||
The committers are responsible for establishing the project's overarching workflow, including issuing releases and security issue reporting policies. | ||
|
||
### Approving and implementing policies and processes for contributing (as published in the CONTRIBUTING file). | ||
|
||
### Discussions, seeking consensus, and where necessary, voting on technical matters relating to the codebase that affect multiple projects. | ||
|
||
The committers are responsible for making important technical decisions related to the codebase through discussions, seeking consensus, | ||
and where necessary, voting to ensure transparency and accountability in the decision-making process. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One open is PR progress tracking. Should committers responsible for PR progress or we leave it to contributor? If the PR itself have potential but original submitter no longer have time to work on it, what would be the right action to do? We might need a next level PR guideline document on these details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delock, I agree that we need more clarity here. To reduce committer burden, I think committers should engage with PRs when the contributor requests a review (or come out of Draft mode). So, there will be two cases of abandoned PRs.
If the PR is of great interest, then it is likely that someone else will pick it up. If under review, the involved committer could choose to complete it.
@PKUWZP and @stas00, would love to get your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also learn from other repos like HF transformers and Pytorch on their process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delock @sfc-gh-truwase I agree with both of you that we need a better mechanism to handle incoming PRs. Here are my thoughts: 1. We can introduce the "two-stage" review process (similar to the AI conference paper reviews). If the PR quality below certain threshold or is not promising/interesting to the community, we can introduce "desk-reject" to close it out before reviewing it further; 2. I agree with Tunji that for the interesting PRs, if no actions are taken after X numbers of days, we can close it and convert it into a RFC; The committer who choose to complete it should work on it, or he/she can invite other contributors to complete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there can be guidelines about how contributor committers do things wrt whether they bring the PR to the finish line or not if the original PR creator is gone.
If one or more persons are interested in completing the PR they will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nobody wants to continue engaging it's probably fine to auto-close the PR after 1 month of no activity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will incorporate the suggestions and modify the PR shortly.