Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion COMMITTERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
| Minjia Zhang | [minjiazhang](https://github.com/minjiazhang) | UIUC |
| Ashwin Aji | [ashwinma](https://github.com/ashwinma) | AMD |
| Sam Foreman | [saforem2](https://github.com/saforem2) | Argonne National Laboratory |
| Zhipeng Wang | [PKUWZP](https://github.com/PKUWZP) | LinkedIn |
| Zhipeng Wang | [PKUWZP](https://github.com/PKUWZP) | LinkedIn |
41 changes: 41 additions & 0 deletions COMMITTERS_RESPONSIBILITY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Responsibilities of the DeepSpeed Committers

The Committer of the DeepSpeed project will be responsible for overseeing the project, with particular responsibilities described as following:

### Reviewing Pull Requests, Issues and Proposals (RFCs) in a timely manner, and help maintain the necessary code quality for all contributions.

Committers are responsible for maintaining the quality of the codebase and ensuring that contributions meet the project's standards.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open is PR progress tracking. Should committers responsible for PR progress or we leave it to contributor? If the PR itself have potential but original submitter no longer have time to work on it, what would be the right action to do? We might need a next level PR guideline document on these details.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delock, I agree that we need more clarity here. To reduce committer burden, I think committers should engage with PRs when the contributor requests a review (or come out of Draft mode). So, there will be two cases of abandoned PRs.

  1. Draft PRs - I think we can configure automatic closing after X number of days of no activity
  2. Under review - Committer who is tracking progress can decide when to close.

If the PR is of great interest, then it is likely that someone else will pick it up. If under review, the involved committer could choose to complete it.

@PKUWZP and @stas00, would love to get your thoughts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also learn from other repos like HF transformers and Pytorch on their process.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delock @sfc-gh-truwase I agree with both of you that we need a better mechanism to handle incoming PRs. Here are my thoughts: 1. We can introduce the "two-stage" review process (similar to the AI conference paper reviews). If the PR quality below certain threshold or is not promising/interesting to the community, we can introduce "desk-reject" to close it out before reviewing it further; 2. I agree with Tunji that for the interesting PRs, if no actions are taken after X numbers of days, we can close it and convert it into a RFC; The committer who choose to complete it should work on it, or he/she can invite other contributors to complete it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there can be guidelines about how contributor committers do things wrt whether they bring the PR to the finish line or not if the original PR creator is gone.

If one or more persons are interested in completing the PR they will.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody wants to continue engaging it's probably fine to auto-close the PR after 1 month of no activity.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will incorporate the suggestions and modify the PR shortly.

More specifically, this includes timely reviewing the incoming pull requests (PR), issues and proposals (RFCs), and routing the PRs to
the right owners for high quality reviews. Committers are also responsible for providing constructive feedback to contributors,
helping to maintain the code quality for all code merges/contributions.


### Setting up the long-term technical roadmaps and strategic vision for the DeepSpeed project.

Given the rapid development of the AI and ML ecosystem, the committers are responsible for periodically reviewing the unique value proposition
of the DeepSpeed project, and hold discussions internally to establish the long-term technical roadmaps for the project development.
Also the committers are responsible for setting up the strategic vision, which includes building and growing the contributor community,
and improving adoption and compatibility in the fast-evolving AI ecosystem.

### Leading the collaboration to work with other open source or open standards communities.

The committers are responsible for coordinating and collaborating with other open source or open standards communities to improve
DeepSpeed's compatibility and interoperability with other projects. The committers are also responsible for holding discussions
internally to reach consensus on what open source projects to collaborate with, and how to position DeepSpeed in the open source ecosystem.

### Organizing the DeepSpeed Community Meetups, Marketing and Events etc. Maintaining the DeepSpeed Website and monitoring the Social Media Platforms.

The committers are responsible for organizing the DeepSpeed community meetups, Marketing and Events etc. They are also responsible
for maintaining/updating the DeepSpeed website, and monitor/steering the DeepSpeed social media platforms to maintain the healthy culture
of the discussions.

### Establishing community norms, workflows, issuing releases, and security issue reporting policies.

The committers are responsible for establishing the project's overarching workflow, including issuing releases and security issue reporting policies.

### Approving and implementing policies and processes for contributing (as published in the CONTRIBUTING file).

### Discussions, seeking consensus, and where necessary, voting on technical matters relating to the codebase that affect multiple projects.

The committers are responsible for making important technical decisions related to the codebase through discussions, seeking consensus,
and where necessary, voting to ensure transparency and accountability in the decision-making process.
Loading