Skip to content

fix: OpenAIChatGenerator - improve the logic to exclude custom tool calls #9725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix: OpenAIChatGenerator - improve the logic to exclude custom tool calls #9725

merged 1 commit into from
Aug 20, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Aug 20, 2025 •
edited
Loading

Related Issues

Failing Mistral tests after 2.17.0 release: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/17085056523/job/48447452402

Proposed Changes:

  • improve the logic to exclude unsupported custom tool calls

How did you test it?

CI; locally tested with Mistral integration

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 changed the title fix: OpenAIChatGenerator - improve the logic to exclude custom tool c… fix: OpenAIChatGenerator - improve the logic to exclude custom tool calls Aug 20, 2025
@anakin87 anakin87 marked this pull request as ready for review August 20, 2025 08:19
@anakin87 anakin87 requested a review from a team as a code owner August 20, 2025 08:19
@anakin87 anakin87 requested review from julian-risch and removed request for a team August 20, 2025 08:19
@anakin87 anakin87 changed the title fix: OpenAIChatGenerator - improve the logic to exclude custom tool calls fix: OpenAIChatGenerator - improve the logic to exclude custom tool calls Aug 20, 2025
@anakin87 anakin87 requested a review from sjrl August 20, 2025 08:20
@anakin87 anakin87 self-assigned this Aug 20, 2025
sjrl
sjrl approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix on this!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17092697650

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 92.167%
Files with Coverage Reduction New Missed Lines %
components/generators/chat/openai.py 6 96.41%
Totals Coverage Status
Change from base Build 17091744421: 0.0%
Covered Lines: 12907
Relevant Lines: 14004
💛 - Coveralls

@anakin87 anakin87 enabled auto-merge (squash) August 20, 2025 08:22
@anakin87 anakin87 merged commit f4db645 into main Aug 20, 2025
23 checks passed
@anakin87 anakin87 deleted the openai-exclude-custom-tcs branch August 20, 2025 08:26
anakin87 added a commit that referenced this pull request Aug 20, 2025
@anakin87
fix: OpenAIChatGenerator - improve the logic to exclude custom tool c…
e2402a3 
…alls (#9725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrl sjrl sjrl approved these changes

@julian-risch julian-risch Awaiting requested review from julian-risch julian-risch is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

@anakin87 anakin87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @sjrl