Skip to content

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Aug 11, 2025

Related Issues

Proposed Changes:

Updated SentenceWindowRetriever's source_id_meta_field parameter to also accept a list of strings. If a list of fields are provided, then only documents matching both fields will be retrieved.

How did you test it?

Added a unit test.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Aug 11, 2025
@coveralls
Copy link
Collaborator

coveralls commented Aug 11, 2025

Pull Request Test Coverage Report for Build 16933015230

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 134 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.2%) to 92.184%

Files with Coverage Reduction New Missed Lines %
components/embedders/sentence_transformers_document_embedder.py 2 96.97%
components/classifiers/zero_shot_document_classifier.py 3 91.53%
components/embedders/hugging_face_api_document_embedder.py 3 96.52%
components/retrievers/sentence_window_retriever.py 6 90.91%
components/extractors/llm_metadata_extractor.py 7 82.61%
components/tools/tool_invoker.py 8 96.31%
components/generators/chat/hugging_face_api.py 9 95.41%
components/embedders/openai_document_embedder.py 20 67.72%
components/extractors/named_entity_extractor.py 26 69.68%
core/pipeline/base.py 50 86.92%
Totals Coverage Status
Change from base Build 16874286199: 0.2%
Covered Lines: 12891
Relevant Lines: 13984

💛 - Coveralls

@sjrl sjrl marked this pull request as ready for review August 12, 2025 07:23
@sjrl sjrl requested a review from a team as a code owner August 12, 2025 07:23
@sjrl sjrl requested review from Amnah199 and ju-gu and removed request for a team August 12, 2025 07:23
Copy link
Member

@ju-gu ju-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for implementing this!

@sjrl sjrl requested a review from Amnah199 August 13, 2025 09:19
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@sjrl sjrl merged commit c7256b2 into main Aug 13, 2025
19 checks passed
@sjrl sjrl deleted the sentence-window-retriever branch August 13, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple metadatafields in the Sentence Window retriever
4 participants