Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing from_dict/to_dict AWS tests #8840

Merged

Conversation

davidsbatista
Copy link
Contributor

Proposed Changes:

  • removing AWS Bedrock related tests, removing extra dependencies from pyproject.toml

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 11, 2025
@anakin87 anakin87 self-requested a review February 11, 2025 09:24
@davidsbatista davidsbatista marked this pull request as ready for review February 11, 2025 09:24
@davidsbatista davidsbatista requested a review from a team as a code owner February 11, 2025 09:24
@davidsbatista davidsbatista requested review from Amnah199 and removed request for a team February 11, 2025 09:24
@davidsbatista davidsbatista enabled auto-merge (squash) February 11, 2025 09:35
@anakin87 anakin87 changed the title removint from_dict/to_dict AWS tests removing from_dict/to_dict AWS tests Feb 11, 2025
@davidsbatista davidsbatista merged commit f189a1c into main Feb 11, 2025
31 checks passed
@davidsbatista davidsbatista deleted the LLMMetaDataExtractor-remove-core-integrations-test branch February 11, 2025 09:40
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13259653573

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 91.449%

Files with Coverage Reduction New Missed Lines %
components/extractors/llm_metadata_extractor.py 4 68.75%
Totals Coverage Status
Change from base Build 13258777131: -0.01%
Covered Lines: 9411
Relevant Lines: 10291

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants