Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AsyncPipeline that can schedule components to run concurrently #8812

Open
wants to merge 86 commits into
base: main
Choose a base branch
from

Conversation

mathislucka
Copy link
Member

Related Issues

Proposed Changes:

Implements an AsyncPipeline that supports:

  • running pipelines asynchronously
  • step-by-step execution through an async generator
  • concurrent execution of components whenever possible (e.g. hybrid retrieval, multiple generators that can run in parallel)
  • sync run-method with concurrent execution of components

How did you test it?

  • unit tests
  • adapted behavioral tests to use Pipeline and AsyncPipeline

Notes for the reviewer

Review after #8707
Code was reviewed here before: deepset-ai/haystack-experimental#180

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mathislucka mathislucka requested review from a team as code owners February 4, 2025 17:04
@mathislucka mathislucka requested review from dfokina and vblagoje and removed request for a team February 4, 2025 17:04
@mathislucka mathislucka added this to the 2.10.0 milestone Feb 4, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13159781039

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.9%) to 92.232%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 1 96.43%
core/pipeline/base.py 19 94.59%
Totals Coverage Status
Change from base Build 13141979385: 0.9%
Covered Lines: 9059
Relevant Lines: 9822

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants