Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a ListJoiner component #8810

Merged
merged 6 commits into from
Feb 5, 2025
Merged

feat: Add a ListJoiner component #8810

merged 6 commits into from
Feb 5, 2025

Conversation

Amnah199
Copy link
Contributor

@Amnah199 Amnah199 commented Feb 4, 2025

Related Issues

Proposed Changes:

Add a new component to join various input lists into a single list.

How did you test it?

Added new unit tests
CI

Notes for the reviewer

Review the use of

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Feb 4, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13167157970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.318%

Totals Coverage Status
Change from base Build 13161624824: 0.02%
Covered Lines: 8972
Relevant Lines: 9825

💛 - Coveralls

@Amnah199 Amnah199 marked this pull request as ready for review February 5, 2025 10:30
@Amnah199 Amnah199 requested review from a team as code owners February 5, 2025 10:30
@Amnah199 Amnah199 requested review from dfokina and davidsbatista and removed request for a team February 5, 2025 10:30
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just two minor comments

@Amnah199 Amnah199 merged commit b0809b7 into main Feb 5, 2025
18 checks passed
@Amnah199 Amnah199 deleted the add-list-joiner branch February 5, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ListJoiner Component to Merge Multiple Lists into a Single List
3 participants