Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate dataframe field in Document and ExtractedTableAnswer #8789

Merged
merged 2 commits into from
Jan 31, 2025
Merged

chore: deprecate dataframe field in Document and ExtractedTableAnswer #8789

merged 2 commits into from
Jan 31, 2025

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • deprecate dataframe field in Document
  • deprecate ExtractedTableAnswer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 marked this pull request as ready for review January 30, 2025 17:14
@anakin87 anakin87 requested review from a team as code owners January 30, 2025 17:14
@anakin87 anakin87 requested review from dfokina and Amnah199 and removed request for a team January 30, 2025 17:14
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13057568264

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.359%
Files with Coverage Reduction New Missed Lines %
dataclasses/answer.py 2 97.94%
dataclasses/document.py 6 93.52%
Totals Coverage Status
Change from base Build 13009290316: 0.007%
Covered Lines: 8871
Relevant Lines: 9710
💛 - Coveralls

@anakin87 anakin87 added this to the 2.10.0 milestone Jan 31, 2025
@davidsbatista
Copy link
Contributor

LGTM 👍🏽

@anakin87 anakin87 merged commit 80575a7 into main Jan 31, 2025
18 checks passed
@anakin87 anakin87 deleted the deprecate-dataframe branch January 31, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@Amnah199 Amnah199 Amnah199 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anakin87 @coveralls @davidsbatista @Amnah199