Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix HF API flaky live test with tools #8744

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • use a more reliable model for the test (it's not easy to find alternatives, because the model should be warm and not gated)
  • add the flaky marker to retry the live tests in this test suite if failing (unfortunately, the LM response is cached, so the marker only helps with network issues, etc.)

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 requested a review from a team as a code owner January 17, 2025 12:21
@anakin87 anakin87 requested review from vblagoje and davidsbatista and removed request for a team January 17, 2025 12:21
@anakin87 anakin87 enabled auto-merge (squash) January 17, 2025 12:25
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12828961994

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.302%

Totals Coverage Status
Change from base Build 12826740828: 0.0%
Covered Lines: 8849
Relevant Lines: 9692

💛 - Coveralls

@anakin87 anakin87 merged commit 424bce2 into main Jan 17, 2025
15 checks passed
@anakin87 anakin87 deleted the fix-hfapi-flaky-tool-test branch January 17, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants