Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added isort #5933

Merged
merged 2 commits into from
Oct 3, 2023
Merged

ci: added isort #5933

merged 2 commits into from
Oct 3, 2023

Conversation

mjspeck
Copy link
Contributor

@mjspeck mjspeck commented Sep 29, 2023

Related Issues

Proposed Changes:

Added isort to pyproject.toml and .pre-commit-config.yaml

How did you test it?

manual verification

Notes for the reviewer

  • Have not committed changes using isort because that will change a lot of code and make seeing the important changes difficult.
  • I have not yet modified any github pipeline files since it would probably make sense to talk with a maintainer about that.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 3, 2023
@silvanocerza silvanocerza marked this pull request as ready for review October 3, 2023 22:04
@silvanocerza silvanocerza requested a review from a team as a code owner October 3, 2023 22:04
@silvanocerza silvanocerza requested review from anakin87 and removed request for a team October 3, 2023 22:04
@silvanocerza
Copy link
Contributor

I believe this to be in a good enough state so I marked it as ready to review to approve it.
In following PRs we can add a CI check and format all the files that require it.

@silvanocerza silvanocerza removed the request for review from anakin87 October 3, 2023 22:05
@silvanocerza silvanocerza merged commit 6424354 into deepset-ai:main Oct 3, 2023
112 of 113 checks passed
@mjspeck mjspeck deleted the ci-#5931-isort branch October 3, 2023 23:43
vblagoje added a commit that referenced this pull request Oct 5, 2023
vblagoje added a commit that referenced this pull request Oct 5, 2023
@mjspeck mjspeck restored the ci-#5931-isort branch October 7, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies topic:DX Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort imports with isort
2 participants