fix: scope logging handler to haystack logger, not root#11567
Closed
sanjuchand wants to merge 1 commit into
Closed
fix: scope logging handler to haystack logger, not root#11567sanjuchand wants to merge 1 commit into
sanjuchand wants to merge 1 commit into
Conversation
configure_logging() was adding its StreamHandler to the root logger,
which silently breaks any application that calls logging.basicConfig()
after importing Haystack (basicConfig is a no-op once handlers exist).
Scope the handler to logging.getLogger("haystack") instead, following
the Python logging docs' guidance that libraries must not configure
root logger handlers.
Fixes deepset-ai#8681
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@sanjuchand is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Author
|
Closing as a duplicate of #11553, which covers the same fix and was opened earlier today. Good luck with the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8681.
configure_logging()was adding itsStreamHandlerto the root logger, which violates Python's logging best practices for libraries and silently breaks any application that callslogging.basicConfig()after importing Haystack —basicConfigis documented as a no-op once any handlers are already registered on the root logger.Change: Scope the
HaystackLoggingHandlertologging.getLogger("haystack")instead oflogging.getLogger()(root). This means the structured formatter applies to allhaystack.*loggers as before, but no longer pollutes the root logger.Test plan
reset_logging_configfixture to resethaystacklogger handlers (not root)haystack.testnamespace so they route through the scoped handlerTestRootLoggerNotModifiedwith two new tests:test_configure_logging_does_not_add_handler_to_root_logger— regression test for the exact bugtest_configure_logging_adds_handler_to_haystack_logger— confirms the handler lands in the right place🤖 Generated with Claude Code