ci: simplify GitHub-Slack communication in the release process#10739
ci: simplify GitHub-Slack communication in the release process#10739
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| # For RCs, request testing from Platform Engineering | ||
| if [[ "${IS_RC}" == "true" ]]; then | ||
| TXT+=$'\n\n'"This release is marked as a Release Candidate." | ||
| TXT+=$'\n'"Comment on this message and tag Platform Engineering to request testing on both Platform and DC custom nodes." |
There was a problem hiding this comment.
this was originally included in the DD monitor, which we skip now
There was a problem hiding this comment.
Could we tag Platform Engineering automatically already here with @platform-eng - don't know if it will render as plain text or as a link in Slack
There was a problem hiding this comment.
If we want to tag them, we would need the Slack group ID (easy to get).
But my original idea was: let's have the release manager decide and avoid noise. It might happen that the RC does not need nesting or that the release manager prefers to send a private message to a person...
There was a problem hiding this comment.
ah got it - makes sense 👍🏽
davidsbatista
left a comment
davidsbatista
left a comment
There was a problem hiding this comment.
LGTM! Left one suggestion to explore but feel free to merge
| # For RCs, request testing from Platform Engineering | ||
| if [[ "${IS_RC}" == "true" ]]; then | ||
| TXT+=$'\n\n'"This release is marked as a Release Candidate." | ||
| TXT+=$'\n'"Comment on this message and tag Platform Engineering to request testing on both Platform and DC custom nodes." |
There was a problem hiding this comment.
Could we tag Platform Engineering automatically already here with @platform-eng - don't know if it will render as plain text or as a link in Slack
2 participants
Related Issues
Proposed Changes:
During the release process, instead of sending DD events and then Slack notifications from DD monitors, skip DD
slackapi/slack-github-actionin the release workflowTo make this work, before opening this PR, I completed the setup described in the Slack documentation.
How did you test it?
Can't trigger the workflow without issuing a release
but I ran the script locally and sent its output to Slack using the Webhook
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.